add new endpoint to fetch node features #2422
Conversation
client/node.go
Outdated
| @@ -322,6 +320,13 @@ func (n *NodeClient) NetworkGetPublicConfig(ctx context.Context) (cfg pkg.Public | |||
| return | |||
| } | |||
|
|
|||
| func (n *NodeClient) NetworkGetNodeFeatures(ctx context.Context) (feat pkg.NodeFeatures, err error) { | |||
| const cmd = "zos.network.node_features_get" | |||
There was a problem hiding this comment.
Why on the zos.network? I assumed it will be on zos.system.node_features
There was a problem hiding this comment.
since this is related to netowrkd-light I assumed it would be on network, but can move it to be system.node_features
There was a problem hiding this comment.
My reasoning is as a user I should ask the node what version do you have? (which is zos.system.version) or what features are enabled on the node so zos.system.node_features_get
pkg/network.go
Outdated
| @@ -257,6 +260,32 @@ type PublicConfig struct { | |||
| Domain string `json:"domain"` | |||
| } | |||
|
|
|||
| type NodeFeatures struct { | |||
There was a problem hiding this comment.
NodeFeatures should have been a slice of a Feature []Feature and that feature is a typed string that can be any of `zdb, zmachine, .. etc)
pkg/monitor.go
Outdated
| // SystemMonitor interface (provided by noded) | ||
| type SystemMonitor interface { | ||
| NodeID() uint32 | ||
| Memory(ctx context.Context) <-chan VirtualMemoryStat | ||
| CPU(ctx context.Context) <-chan TimesStat | ||
| Disks(ctx context.Context) <-chan DisksIOCountersStat | ||
| Nics(ctx context.Context) <-chan NicsIOCounterStat | ||
| GetNodeFeatures() ([]NodeFeature, error) |
There was a problem hiding this comment.
About the suggested interface, will this ever fail? worst case would be an empty slice :)
Eslam-Nawara
requested review from
muhamadazmy,
delandtj,
MarioBassem,
ashraffouda and
rawdaGastan
as code owners
Description
add new endpoint to fetch node features
Changes
add new endpoint to fetch node features
Related Issues
Checklist