use chain to get version and safe to upgrade flag #2431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawdaGastan
requested review from
muhamadazmy,
Omarabdul3ziz,
ashraffouda,
xmonader and
Eslam-Nawara
as code owners
ashraffouda
reviewed
Oct 2, 2024
| return ChainVersion{}, nil, errors.Wrap(err, "failed to get zos version from chain") | ||
| } | ||
|
|
||
| var chainVersion ChainVersion |
There was a problem hiding this comment.
we need to handle old version style for a while just in case it is not updated on some envs
rawdaGastan
force-pushed
the
development_chain_rollout
branch
from
996cbbe
to
ae2c2fd
Compare
ashraffouda
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues