This repository has been archived by the owner on Apr 19, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
Added more env vars to be configurable, all of them are required to run the server. #508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Omarabdul3ziz and
amiraabouhadid
as code owners
February 13, 2023 12:23
AhmedHanafy725
suggested changes
Feb 13, 2023
also, make sure to use the relay is not hard coded, should be used from the config |
Mahmoud-Emad
force-pushed
the
development_env_vars_configuration
branch
from
February 13, 2023 14:38
fd926de
to
61f5e46
Compare
…ser selects this mode he can modify his own environment with all required env vars
Mahmoud-Emad
force-pushed
the
development_env_vars_configuration
branch
from
February 15, 2023 14:29
47c3849
to
86cad41
Compare
Omarabdul3ziz
approved these changes
Feb 16, 2023
AhmedHanafy725
approved these changes
Feb 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues