Skip to content
This repository has been archived by the owner on Apr 19, 2023. It is now read-only.

Fix some farms filters #529

Merged
merged 2 commits into from
Feb 26, 2023
Merged

Fix some farms filters #529

merged 2 commits into from
Feb 26, 2023

Conversation

Omarabdul3ziz
Copy link
Contributor

Changes

  • remove the conversion to number for a text field Certification Type
  • change the validation for Pricing Policies Ids from textual to number.
  • add call to get the available values for Pricing Policies Ids

Related Issues

@Omarabdul3ziz Omarabdul3ziz changed the title Development farm filters fix Fix some farms filters Feb 23, 2023
Mahmoud-Emad
Mahmoud-Emad approved these changes Feb 26, 2023
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mahmoud-Emad Mahmoud-Emad merged commit a755eb7 into development Feb 26, 2023
@Mahmoud-Emad Mahmoud-Emad deleted the development_farm_filters_fix branch February 26, 2023 16:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725

@zaelgohary zaelgohary Awaiting requested review from zaelgohary

@maayarosama maayarosama Awaiting requested review from maayarosama

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Omarabdul3ziz @Mahmoud-Emad