opt: introduce a leaf cache #543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 4, 2024
pepyakin
approved these changes
Nov 5, 2024
| @@ -108,6 +110,7 @@ impl Tree { | |||
| bbn_store, | |||
| primary_staging: BTreeMap::new(), | |||
| secondary_staging: None, | |||
| leaf_cache: leaf_cache::LeafCache::new(32, 1 << 16), | |||
There was a problem hiding this comment.
Those numbers look magic-y. I assume this is/will be changed in the following PRs.
There was a problem hiding this comment.
Definitely, just like the merkle page cache we need to add this to the public API
rphmeier
force-pushed
the
rh-leaf-cache
branch
3 times, most recently
from
5b6f729 to
97806a3
Compare
gabriele-0201
approved these changes
Nov 26, 2024
|
OP is confusing, is it ready to land or not? |
rphmeier
force-pushed
the
rh-leaf-cache
branch
from
97806a3 to
c92ccf5
Compare
|
Yes, I believe it's ready for merge (with the stack above it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is super raw; will be refined in later PRs. Let's not merge until the full stack is ready.
The cache is populated when leaves are read and when the workload creates new leaves.