Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

opt: BranchNode::set_prefix uses bitwise_memcpy #569

Merged
merged 1 commit into from
Dec 5, 2024
Merged

opt: BranchNode::set_prefix uses bitwise_memcpy #569

merged 1 commit into from
Dec 5, 2024

Conversation

gabriele-0201
Copy link
Contributor

No description provided.

This was referenced Nov 19, 2024
Merged
Merged
Closed
Merged
@gabriele-0201 Graphite App
Copy link
Contributor Author

gabriele-0201 commented Nov 19, 2024 •
edited by rphmeier
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@gabriele-0201 gabriele-0201 mentioned this pull request Nov 19, 2024
Closed
@gabriele-0201 gabriele-0201 force-pushed the gm_branch_builder_push_chunk_opt branch from 9e68d06 to 3941ad8 Compare November 19, 2024 08:51
@gabriele-0201 gabriele-0201 force-pushed the gm_brach_set_prefix_uses_bitwise_memcpy branch from f3e7dfd to 64bb89c Compare November 19, 2024 08:52
rphmeier
rphmeier approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@rphmeier rphmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The refactor to extract bitwise memcpy makes a lot of sense.

@gabriele-0201 gabriele-0201 force-pushed the gm_brach_set_prefix_uses_bitwise_memcpy branch from 64bb89c to 6337edb Compare November 27, 2024 07:29
@gabriele-0201 gabriele-0201 changed the base branch from gm_branch_builder_push_chunk_opt to gm_branch_node_push_chunk_opt_ November 27, 2024 07:29
This was referenced Nov 27, 2024
Merged
Merged
Merged
@rphmeier rphmeier force-pushed the gm_branch_node_push_chunk_opt_ branch from 871ebd8 to 48b7623 Compare December 5, 2024 19:59
@rphmeier rphmeier force-pushed the gm_brach_set_prefix_uses_bitwise_memcpy branch from 6337edb to 102637d Compare December 5, 2024 19:59
@rphmeier Graphite App
Copy link
Contributor

rphmeier commented Dec 5, 2024 •
edited
Loading

Merge activity

  • Dec 5, 3:42 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Dec 5, 3:44 PM EST: Graphite rebased this pull request as part of a merge.
  • Dec 5, 3:45 PM EST: A user merged this pull request with Graphite.

@rphmeier rphmeier changed the base branch from gm_branch_node_push_chunk_opt_ to graphite-base/569 December 5, 2024 20:42
@rphmeier rphmeier changed the base branch from graphite-base/569 to master December 5, 2024 20:42
@rphmeier rphmeier force-pushed the gm_brach_set_prefix_uses_bitwise_memcpy branch from 102637d to 4d2dc00 Compare December 5, 2024 20:43
@rphmeier rphmeier merged commit 1650469 into master Dec 5, 2024
8 checks passed
@rphmeier rphmeier deleted the gm_brach_set_prefix_uses_bitwise_memcpy branch December 5, 2024 20:45
This was referenced Dec 5, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rphmeier rphmeier rphmeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gabriele-0201 @rphmeier