Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: tuck rollback sync #584

Merged
merged 1 commit into from
Nov 29, 2024
Merged

chore: tuck rollback sync #584

merged 1 commit into from
Nov 29, 2024

Conversation

pepyakin
Copy link
Contributor

@pepyakin pepyakin commented Nov 26, 2024 •
edited
Loading

This is the last commit on my quest of splitting up the sync module and isolating each individual component.

Closes THR-33

This was referenced Nov 26, 2024
Merged
Merged
Merged
Merged
Merged
@pepyakin Graphite App
Copy link
Contributor Author

pepyakin commented Nov 26, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pepyakin pepyakin mentioned this pull request Nov 26, 2024
Merged
@pepyakin pepyakin marked this pull request as ready for review November 26, 2024 10:47
@pepyakin pepyakin force-pushed the pep-chore-remove-unused-result branch from 0a7fe6e to 62ef606 Compare November 28, 2024 14:18
@pepyakin pepyakin force-pushed the pep-chore-tuck-rollback-sync branch from df89a71 to 67b78e2 Compare November 28, 2024 14:19
gabriele-0201
gabriele-0201 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@gabriele-0201 gabriele-0201 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now after THR-33 Sync::sync(...) is 63 lines of pure simplicity!

nomt/src/store/sync.rs Show resolved Hide resolved
@pepyakin pepyakin force-pushed the pep-chore-remove-unused-result branch from 62ef606 to 3fe3792 Compare November 29, 2024 16:44
@pepyakin pepyakin force-pushed the pep-chore-tuck-rollback-sync branch 2 times, most recently from 5c3e2f4 to afb1320 Compare November 29, 2024 16:48
@pepyakin Graphite App
Copy link
Contributor Author

pepyakin commented Nov 29, 2024 •
edited
Loading

Merge activity

  • Nov 29, 2:35 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Nov 29, 2:40 PM EST: Graphite rebased this pull request as part of a merge.
  • Nov 29, 2:41 PM EST: A user merged this pull request with Graphite.

@pepyakin pepyakin changed the base branch from pep-chore-remove-unused-result to graphite-base/584 November 29, 2024 19:36
@pepyakin pepyakin changed the base branch from graphite-base/584 to master November 29, 2024 19:38
@pepyakin pepyakin force-pushed the pep-chore-tuck-rollback-sync branch from afb1320 to 9f4fba1 Compare November 29, 2024 19:39
@pepyakin pepyakin merged commit 29014fc into master Nov 29, 2024
8 checks passed
@pepyakin pepyakin deleted the pep-chore-tuck-rollback-sync branch November 29, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriele-0201 gabriele-0201 gabriele-0201 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepyakin @gabriele-0201