refactor(beatree)!: include value hash in overflow cells #602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
rphmeier
force-pushed
the
rh-THR-53-overflow-cell-value-hash
branch
from
86f7e9c to
d1f20ec
Compare
rphmeier
force-pushed
the
rh-THR-53-overflow-cell-value-hash
branch
from
d1f20ec to
ed25760
Compare
pepyakin
reviewed
Dec 7, 2024
| @@ -41,7 +41,7 @@ pub const MAX_LEAF_VALUE_SIZE: usize = (LEAF_NODE_BODY_SIZE / 3) - 32; | |||
| /// The maximum number of node pointers which may appear directly in an overflow cell. | |||
| /// | |||
| /// Note that this gives an overflow value cell maximum size of 100 bytes. | |||
| pub const MAX_OVERFLOW_CELL_NODE_POINTERS: usize = 23; | |||
| pub const MAX_OVERFLOW_CELL_NODE_POINTERS: usize = 15; | |||
There was a problem hiding this comment.
Does this require updating the comment above?
There was a problem hiding this comment.
No. 15*4 + 32 + 8 = 100 still.
|
|
||
| /// Create an insertion, determining whether to use the normal or overflow variant based on size. | ||
| pub fn insert<T: crate::ValueHasher>(v: Vec<u8>) -> Self { | ||
| if v.len() > MAX_LEAF_VALUE_SIZE { |
There was a problem hiding this comment.
Tbf, not sure if this is a good place for such a decision.
There was a problem hiding this comment.
I wasn't sure either, but I would also prefer not to leak MAX_LEAF_VALUE_SIZE anywhere else in the codebase. It should be part of the beatree module, and ValueChange is used everywhere within beatree/mod.rs. This feels like the least-bad option. Do you have another suggestion?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including the value hash in overflow cells enables us to always obtain the value hash associated with any key just by reading the relevant leaf. This is a pre-requisite for removing leaf-children.