fix: adjust BranchOp handling #615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Dec 13, 2024
rphmeier
approved these changes
Dec 13, 2024
rphmeier
reviewed
Dec 13, 2024
rphmeier
reviewed
Dec 13, 2024
rphmeier
reviewed
Dec 13, 2024
rphmeier
reviewed
Dec 13, 2024
rphmeier
reviewed
Dec 13, 2024
gabriele-0201
force-pushed
the
gm_branch_binary_search_not_create_0_sized_chunks
branch
from
51d09f2 to
6841f5a
Compare
gabriele-0201
force-pushed
the
gm_branch_binary_search_fix_uncompressed_separators_handling
branch
from
0157782 to
1b8c19f
Compare
Base automatically changed from
gm_branch_binary_search_not_create_0_sized_chunks
to
master
December 15, 2024 10:23
The changeset not only includes fixes for how uncompressed separators are represented through BranchOp, but also contains a refactor to better encapsulate the update logic of BranchOp.
gabriele-0201
force-pushed
the
gm_branch_binary_search_fix_uncompressed_separators_handling
branch
from
1b8c19f to
d707976
Compare
gabriele-0201
deleted the
gm_branch_binary_search_fix_uncompressed_separators_handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changeset not only includes fixes for how uncompressed separators
are represented through BranchOp, but also contains a refactor
to better encapsulate the update logic of BranchOp.
Note: consume_and_update_until reports the following doc:
This was never really discussed before, but while working on the tests, I noticed how this was expected by the test
shared_prefix_collapse. I thought, besides making sense leading to fewer edge cases, to explicitly state the behavior and ensure it effectively happens. It will be tested by multiple tests in follow-up PRs.