Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisions to the dockerfile #51

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

rpgoldman
Copy link

@rpgoldman rpgoldman commented Aug 15, 2022

There are some issues with the existing Dockerfile. I have added a new one (not preceded by a .) trying to fix it.

So far:

  1. Added more apt package installations, which seem necessary.
  2. Fix the download location for CoCoA. Fixes Link for CoCoA lib download needs update #50

Right now, this does not work. CoCoA does not build correctly. It seems not to find dependencies that are installed.

Add a new dockerfile with additional package installations for
building carl.

1. Added more boost packages
2. Added git configuration (which shouldn't be hard-coded as it
currently is) because it's needed in order for git to be able to apply
patches.

Still fails to successfully build CoCoA.
@rpgoldman
Copy link
Author

I have fixed the CoCoA build problems, which was due to a bug in CoCoA's script for finding the boost libraries: it made assumptions about how boost is installed that are not true, at least on Ubuntu.

Unfortunately, even after the fix, the resulting Docker image does not appear to install CoCoA headers. See smtrat issue 97

I don't know much about cmake, but I wonder if it would make more sense to build and install CoCoA more directly, rather than having cmake do it? The cmake script for installation has to have URLs hard-coded in it, and makes it hard to control CoCoA's configuration. I don't know how this works for a conventional install, but for building a Docker image, at least, it might be nicer to install CoCoA first, using CoCoA's own installation process, and then building carl afterwards. (But in that case, I do not know how one would make the Carl build process find the CoCoA installation.)

@rpgoldman
Copy link
Author

In order to move this past draft status, I need some advice on

  1. revising the git configuration https://github.com/rpgoldman/carl/blob/487b3f3ff05667509412fecfeaf256dc771f7bb3/Dockerfile#L18-L19 and
  2. how to make the location of the boost libraries vary according to the host architecture https://github.com/rpgoldman/carl/blob/487b3f3ff05667509412fecfeaf256dc771f7bb3/Dockerfile#L30

Previously `build/resources/include` wasn't in the C++ compiler's
include list.
@rpgoldman
Copy link
Author

This needs refinement, but it fixes multiple problems with building Carl.

@rpgoldman rpgoldman marked this pull request as ready for review August 23, 2022 23:32
@rpgoldman
Copy link
Author

This needs refinement, but it fixes multiple problems with building Carl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link for CoCoA lib download needs update
1 participant