MINF-2398 Specify collectionSize for collections #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,20 +68,24 @@ import kotlin.reflect.javaType | |||
| * specify a consistent value for this field. | |||
| * @param useNullForNullableFields If true, then all fields that are nullable will be set to null, | |||
| * unless specified in the overrides map. | |||
| * @param collectionSize If specified, supported collection types will be set to that size rather | |||
| * than | |||
There was a problem hiding this comment.
I think the sentence is incomplete?
There was a problem hiding this comment.
I distinctly remember getting distracted with a meeting while writing this, and I guess not finishing the comment when pushing
brian-terczynski
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new parameter for generateTestObject() to specify collection size.
Should the arrays in generateValueForSimpleField() also account for this parameter?