Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial ability to view post/comment reports #1210

Merged
merged 10 commits into from
Mar 27, 2024
Merged

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Mar 18, 2024

Pull Request Description

This PR adds the ability to view post/comment reports. If a user is a moderator for a community, or an admin, a new option will show up on the drawer to open a page containing post and comment reports.

  • By default, it will show post/comment reports that have not yet been resolved.
  • We can perform extra filtering by tapping on the filter icon at the top. This will allow us to show all reports (resolved/unresolved), as well as filter by community.
  • The UI/UX is changed slightly from what we're currently using in other places (e.g., user feed page, inbox page, etc.) The goal here was to make it feel more in touch with Material guidelines. As such, the pill shaped options have been replaced with a tab bar for switching between post/comment reports.

This is the first iteration of this, but I have some ideas for additions to this!

  • Adding in badge counters to show the number of unresolved reports
  • Add the ability to view and resolve private message reports
  • Add in quick actions to each report (e.g., to ban offending user, delete/purge offending content, etc)

@micahmo feel free to take a look through the code, but no need to do a deep dive into it as a lot of new files have been added to support reports

@machinaeZER0 it would be great if you could provide any feedback on the overall UI/UX! I feel like I'm fairly happy with it. The only thing bothering me right now is the contents within the filter bottom sheet (it feels a bit awkward but that might just be me)

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

03cd7a4b-8d05-4d87-bc74-5e286c82e935.mp4

Adding in some static screenshots to get a better view of the UI

simulator_screenshot_CAC3692C-7D91-496F-B4AA-77DA636E67FD simulator_screenshot_0E750637-5F11-4AB6-B132-0DAFF3E8E8C2
simulator_screenshot_9BC04591-235D-4D37-B858-D0BA780A4924 simulator_screenshot_E945AA35-E391-4D78-ADF8-BFA369B8149B

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu hjiangsu marked this pull request as ready for review March 22, 2024 23:20
@hjiangsu hjiangsu changed the title Draft: Post/Comment Reports Initial ability to view post/comment reports Mar 22, 2024
Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, this looks so awesome! I don't really have anything to add to either the code or the UX (without really trying it in-depth myself).

One thing that did come to mind is the filter button. I wonder if we should change the icon slightly when there's a filter applied. The same could be for the modlog.

@machinaeZER0
Copy link
Collaborator

I think this looks great! And I like your ideas for future additions :) honestly I think my only thought would be to better highlight the reason something is reported - feels like an element that would get a custom color or pill treatment, I think?

@hjiangsu
Copy link
Member Author

Thanks for the feedback! I've adjusted it now to make the reason more bolded, and used the error colour to better highlight the reason. Thoughts on this approach?

image image
image image

@machinaeZER0
Copy link
Collaborator

I think that's great! Looks very clean :)

@hjiangsu
Copy link
Member Author

I'll go ahead and merge this in for the initial feature, and we can continue to add on to this as I mentioned in the original description 😄

@hjiangsu hjiangsu merged commit 751bf24 into develop Mar 27, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/reports branch March 27, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants