Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/animated size #1217

Merged
merged 1 commit into from
Mar 20, 2024
Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 20, 2024

Pull Request Description

This PR wraps a couple of bottom sheets (advanced share sheet and link preview) in AnimatedSizes. This just makes the app feel more fluid and smooth.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

qemu-system-x86_64_xMngpt677L.mp4
qemu-system-x86_64_4msKgCieuw.mp4

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 6865148 into thunder-app:develop Mar 20, 2024
1 check passed
@micahmo micahmo deleted the feature/animated-size branch March 21, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants