Handle search result comments on deleted posts #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just as a followup, this has been fixed in the backend in LemmyNet/lemmy#4634. I don't think it hurts to keep our fix though! |
|
Yeah, it doesn't hurt to keep this in (especially for instances on older versions that don't have the fix yet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
I noticed that the Lemmy API returns comments from deleted posts. I debated whether we should exclude such comments from search results entirely, but I figured a big change like that should come from the Lemmy side of things. Instead, I made a change in the UI to indicate that the post is deleted and to prevent navigation.
Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
qemu-system-x86_64_hHgtkVeUWz.mp4
After
qemu-system-x86_64_T9M0QGpJ11.mp4
Checklist
semanticLabels where applicable for accessibility?