Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide usernames on user feeds #1259

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Mar 31, 2024

Pull Request Description

Issue Being Fixed

This PR hides the name of the post author (regardless of the "Show Post Author" setting) when viewing the user feed, since it is redundant. This is similar to how we currently hide the community name when viewing the community feed.

Issue Number: N/A

Screenshots / Recordings

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 8770d2c into thunder-app:develop Apr 2, 2024
1 check passed
@micahmo micahmo deleted the feature/hide-user-on-user-feed branch April 2, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants