Use loading page for posts/comments #1311
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR adds the loading page feature for post and comment links. The loading page was originally added in #1200, and it was to handle the case where we have an ambiguous link for a person or community, so we load the full object to verify whether it really exists before navigating. The loading page helps to bridge the gap while we fetch the object so the user knows something is happening.
I've been noticing that navigating to posts and comments has a similar problem where there seems to be no activity for a period of time (especially on a slower network). I believe this is because we similarly load the whole post/comment object before navigating, and unlike users/communities, we always load posts/comments, making the problem even more obvious. Furthermore, we often have to do a
ResolveObject
if the entity is on a different instance.Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
post-comment-loading-before.mp4
After
post-comment-loading-after.mp4
Checklist
semanticLabel
s where applicable for accessibility?