Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sort inbox #1373

Merged
merged 4 commits into from
Jul 8, 2024
Merged

sort inbox #1373

merged 4 commits into from
Jul 8, 2024

Conversation

ggichure
Copy link
Collaborator

Pull Request Description

This PR adds the ability to sort inbox items by hot top new e.t.c. Uses Default comments sort.

Issue Being Fixed

Issue Number: #1118

Screenshots / Recordings

Screenshot_20240519-115146_Thunder

Checklist

  • Did you update CHANGELOG.md?
  • Did you use localized strings where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@hjiangsu
Copy link
Member

hjiangsu commented Jul 8, 2024

A bit of an update here:

  • Since I refactored the inbox page recently, I just updated this PR to work with the refactored inbox page
  • I also shifted around the app bar actions so that it conforms more closely with Material 3 guidelines (max of 3 actions on the app bar)

This is how it looks like now:
Screenshot_1720470052 Screenshot_1720470081

@hjiangsu hjiangsu merged commit a5d7619 into thunder-app:develop Jul 8, 2024
1 check passed
@ggichure ggichure mentioned this pull request Aug 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hjiangsu hjiangsu hjiangsu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ggichure @hjiangsu