A number of link sharing improvements #1398
Conversation
|
The problem was Thunder currently doesn't use the actual post URL for images. It always uses the cached copy on the pict-rs server of your instance. There is hence no way to download, view, or share, the actual source media. |
Ok thanks for the reminder! I believe this PR fixes the "share" issue. I will see about viewing and downloading. |
|
Alright, I pushed another change which adds a new I also got rid of the "Share Thumbnail As Image" option from the share menu (since that didn't seem super useful to me) and added a "Share Image" option instead, using the new Examples
|
| @@ -162,7 +162,7 @@ class _MediaViewState extends State<MediaView> with SingleTickerProviderStateMix | |||
| }, | |||
| pageBuilder: (BuildContext context, Animation<double> animation, Animation<double> secondaryAnimation) { | |||
| return ImageViewer( | |||
| url: widget.postViewMedia.media.first.thumbnailUrl ?? widget.postViewMedia.media.first.originalUrl!, | |||
| url: widget.postViewMedia.media.first.imageUrl, | |||
There was a problem hiding this comment.
Just as a quick note, this might bring back longer loading times for the image URL since we're prioritizing the full image now rather than the thumbnail. This might not be too big of a deal though considering we're deferring the image dimensions!
Regardless, we should monitor the impact this has on loading images 😅
There was a problem hiding this comment.
Hmm, that's a good point. I'm not sure the best way to handle this, though, because people could be equally upset about the long load times as the fact that we weren't showing the full-resolution image. It's kind of a lose-lose. 😆
There was a problem hiding this comment.
Relay used to have and "HD" button in the image viewer which had to be pressed to load full-res images.
You could override this with a setting to always load the full-res image, if bandwidth and time weren't a concern.
There was a problem hiding this comment.
That's definitely a good idea for a future enhancement.
- By default, load the thumbnail; have a button for the user to load full-res
- Have an option to load full-res always, only on Wi-Fi, etc. (similar to video options)
Pull Request Description
This PR fixes a few issues with sharing that have been brought up in the Matrix chat and other PRs.
"Share Media" has been renamed to "Share Thumbnail As Image", since that's what it's really doing. (Note that this can be the same image as the full-size image, but the difference is that it's sharing the image itself, not a link.)This has changed slightly, please read the latest comments.mediaUrl. This handles the fact that videos previously couldn't be shared. It also fixes a problem where you could only share the thumbnail-resolution variant of an image (if it was on your instance). Note that this can be the same link as "Share Thumbnail As Image" if the instance didn't generate a separate thumbnail, but that's ok because the share actions are distinct.linktype (sometimes the original link differs from the media link, so it's helpful to have both).@CTalvio I seem to recall you mentioned something about us either displaying or sharing the wrong resolution version of images, but I couldn't find the conversation in Matrix. Do you recall the exact problem, and does anything here fix that?
Screenshots
Ability to share thumbnail as image + link to article
Ability to share thumbnail as image + link to full-size image
Ability to share thumbnail as image + link to full-size image (where thumbnail and full-size are same)
Ability to share link to video + ability to share "original URL" when it's different