Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make snackbar responsive to keyboard #1439

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jun 10, 2024

Pull Request Description

This PR allows the snackbar to responsively change height in response to things like the keyboard.

Hide whitespace.

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Before

qemu-system-x86_64_6dS8S6aNkS.mp4

After

qemu-system-x86_64_Zl2kFwU6dd.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This was also something that was bothering me a bit so thanks for working on it!

@hjiangsu hjiangsu merged commit 7318dd5 into thunder-app:develop Jun 12, 2024
1 check passed
@micahmo micahmo deleted the fix/snackbar-keyboard branch June 12, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants