Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected a minor typo in 'Change Password' page #1468

Merged
merged 10 commits into from
Jun 25, 2024

Conversation

wadamT
Copy link
Contributor

@wadamT wadamT commented Jun 24, 2024

Pull Request Description

Formatted 'next line' correctly in Account Settings> Change Password page.

Issue Being Fixed

Screenshot_20240614-040829_Thunder

@micahmo micahmo mentioned this pull request Jun 24, 2024
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure to remove the newline here so that it passes the CI!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wadamT Your PR now includes a new file, lib/app_en.arb. Once you delete that, this should be good to go!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@micahmo Done.

@hjiangsu hjiangsu merged commit 70ebd93 into thunder-app:develop Jun 25, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants