Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show site content warnings #1485

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Jul 10, 2024

Pull Request Description

This PR adds support for the new site content warning in 0.19.4.

See: LemmyNet/lemmy#4393

When adding an account or anonymous instance, we will check if the instance has a content warning. If so, we will show it to the user. If they decline, we will cancel adding the account.

If you look at the linked Lemmy PR, you'll see two other things mentioned.

  • They say that you should not blur NSFW previews on instances that have a content warning. However, it doesn't look like the Lemmy web UI itself respects this recommendation, so for now I did not make any changes in Thunder. At the very least, I think we should add the "Blur NSFW content" setting to the account settings page to sync with Lemmy, and move our existing "Blur NSFW Previews" setting to the guest feed area. But that can be later.
  • It also mentions that communities should have a new only_followers_can_vote setting, and that client should disable vote buttons if the setting is enabled and the user is not a subscriber. But I couldn't find a place to enable this setting on our 0.19.5 instance, so I skipped this as well.

Issue Being Fixed

Issue Number: #1447

Screenshots / Recordings

qemu-system-x86_64_K0vELQwoIN.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

@micahmo micahmo mentioned this pull request Jul 10, 2024
7 tasks
Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit d573b41 into thunder-app:develop Jul 16, 2024
1 check passed
@micahmo micahmo deleted the feature/content-warning branch July 16, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants