Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show voting when hidden scores are enabled #1510

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

hjiangsu
Copy link
Member

@hjiangsu hjiangsu commented Aug 1, 2024

Pull Request Description

Review with whitespace off

This PR adds a way to show the voting status of a given post when post scores are hidden. This works with the upvote, downvote, and score metadata widgets.

Issue Being Fixed

Issue Number: Not a specific issue, but feedback from the community post: https://lemmy.world/post/18027749

Screenshots / Recordings

Score Metadata:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-01.at.09.57.47.mp4

Upvote/Downvote Metadata:

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-08-01.at.09.59.24.mp4

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 51a7a7b into develop Aug 1, 2024
1 check passed
@hjiangsu hjiangsu deleted the feature/show-votes-hidden-scores branch August 1, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants