Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post submit; update comment submit #1512

Merged

Conversation

micahmo
Copy link
Member

@micahmo micahmo commented Aug 5, 2024

Pull Request Description

This PR changes the submit button into a spinner when the post is currently being submitted (this was lost in #1498 when the submit button was redesigned).

This PR also applies a similar design change to the create comment page.

Copy link
Member

@hjiangsu hjiangsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hjiangsu hjiangsu merged commit 590c0e2 into thunder-app:develop Aug 6, 2024
1 check passed
@micahmo micahmo deleted the feature/comment-submit-button branch August 6, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants