Add spotless code formatter #6630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cketti
approved these changes
Feb 6, 2023
cketti
approved these changes
Feb 6, 2023
Goooler
reviewed
Feb 6, 2023
| spotless { | ||
| kotlin { | ||
| ktlint(libs.versions.ktlint.get()) | ||
| .setEditorConfigPath("$projectDir/.editorconfig") |
There was a problem hiding this comment.
Unnecessary override, it's the default.
There was a problem hiding this comment.
Right, I'll create a follow up change
| .setEditorConfigPath("$projectDir/.editorconfig") | ||
| target("**/*.kt") | ||
| targetExclude("**/build/", "**/resources/", "plugins/openpgp-api-lib/") | ||
| endWithNewline() |
There was a problem hiding this comment.
This rule had been covered by insert_final_newline in .editorconfig.
There was a problem hiding this comment.
Right, I'll create a follow up change
| @@ -38,7 +39,7 @@ ksp = "com.google.devtools.ksp:1.8.0-1.0.8" | |||
| kotlin-android = { id = "org.jetbrains.kotlin.android", version.ref = "kotlin" } | |||
| kotlin-parcelize = { id = "org.jetbrains.kotlin.plugin.parcelize", version.ref = "kotlin" } | |||
| kotlin-jvm = { id = "org.jetbrains.kotlin.jvm", version.ref = "kotlin" } | |||
| ktlint = "org.jlleitschuh.gradle.ktlint:11.0.0" | |||
| spotless = { id = "com.diffplug.spotless", version.ref = "spotless" } | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the ktlint plugin to the Spotless Gradle plugin with ktlint support. Spotless also allows to run other formatters, so this comes with Markdown, KTS and misc rules configured.
This spares the Java formatter due to it's massive changeset. A simple rule matching most of current Java code style is:
Due to some issues with ktlint 0.48.x it is still using 0.47.1. Problems expected to be fixed in ktlint 0.49.0
Closes #6605