refactor(preset): explicitly define jsdom for test environment
#621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Nov 10, 2020
jest-preset.js
Outdated
| @@ -11,6 +11,7 @@ module.exports = { | |||
| }, | |||
| }, | |||
| }, | |||
| testEnvironment: 'jest-environment-jsdom-sixteen', | |||
There was a problem hiding this comment.
isn't latest Jest using jsdom v16?
There was a problem hiding this comment.
for some reasons, my latest push isn't affected
There was a problem hiding this comment.
should be good now :)
Jest 27 sets default test environment to `node`. Since we need `jsdom` so we need to explicitly set it in `jest-preset.js`. Jest 27 will still bundle `jest-environment-jsdom` in the main package and Jest 28 will detach them. However, we should just go ahead and set explicitly `jest-environment-jsdom` in our dependencies list More information see https://jestjs.io/blog/2020/05/05/jest-26
thymikee
approved these changes
Nov 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Jest 27 sets default test environment to
node, see jestjs/jest#9874. Since we needjsdomso we need to explicitly set it injest-preset.js.Jest 27 will still bundle
jest-environment-jsdomin the main package and Jest 28 will separate them. However, we should just go ahead and set explicitlyjest-environment-jsdomin our dependencies list.More information see https://jestjs.io/blog/2020/05/05/jest-26
Test plan
Green CI
Does this PR introduce a breaking change?
Other information
N.A>