*: Fix data race in TestSetLabelsConcurrentWithGetLabel (pingcap#45579)

close pingcap#45578
ti-chi-bot · Jul 26, 2023 · 41afaec · 41afaec
1 parent 5a5cad1
commit 41afaec
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/server/http_handler_test.go b/server/http_handler_test.go
@@ -1196,7 +1196,9 @@ func TestSetLabels(t *testing.T) {
 	testUpdateLabels(updated, labels)
 
 	// reset the global variable
-	config.GetGlobalConfig().Labels = map[string]string{}
+	config.UpdateGlobal(func(conf *config.Config) {
+		conf.Labels = map[string]string{}
+	})
 }
 
 func TestSetLabelsConcurrentWithGetLabel(t *testing.T) {
@@ -1237,5 +1239,7 @@ func TestSetLabelsConcurrentWithGetLabel(t *testing.T) {
 	close(done)
 
 	// reset the global variable
-	config.GetGlobalConfig().Labels = map[string]string{}
+	config.UpdateGlobal(func(conf *config.Config) {
+		conf.Labels = map[string]string{}
+	})
 }