Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: update required status for TiCDC #453

Merged
merged 2 commits into from
Nov 3, 2021
Merged

config: update required status for TiCDC #453

merged 2 commits into from
Nov 3, 2021

Conversation

sleepymole
Copy link
Contributor

@sleepymole sleepymole commented Oct 28, 2021 •
edited
Loading

Since we have merged DM repo into TiCDC repo https://github.com/pingcap/ticdc/pull/3122, we need to add idc-jenkins-ci-ticdc/dm-integration-test and idc-jenkins-ci-ticdc/dm-compatibility-test as a required status in TiCDC CI.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 28, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • Mini256

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot
Copy link
Member

Welcome @gozssky!

It looks like this is your first PR to ti-community-infra/configs 🎉.

I'm the bot to help you request reviewers, add labels and more, See available commands.

We want to make sure your contribution gets all the attention it needs!



Thank you, and welcome to ti-community-infra/configs. 😃

@ti-chi-bot
Copy link
Member

Hi @gozssky. Thanks for your PR.

I'm waiting for a ti-community-infra member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot added contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. labels Oct 28, 2021
@ti-chi-bot ti-chi-bot requested a review from Mini256 October 28, 2021 05:59
@ti-chi-bot ti-chi-bot added needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 28, 2021
@sleepymole
Copy link
Contributor Author

/cc @hi-rustin @lichunzhu

@ti-chi-bot
Copy link
Member

@gozssky: GitHub didn't allow me to request PR reviews from the following users: hi-rustin, lichunzhu.

Note that only ti-community-infra members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @hi-rustin @lichunzhu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Mini256
Copy link
Member

Mini256 commented Oct 28, 2021

/ok-to-test

@ti-chi-bot ti-chi-bot added ok-to-test Indicates a PR is ready to be tested. and removed needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. labels Oct 28, 2021
Rustin170506
Rustin170506 approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@Rustin170506 Rustin170506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR desc. Thanks!

LGTM

@ti-chi-bot
Copy link
Member

@hi-rustin: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Please update the PR desc. Thanks!

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@lichunzhu: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@sleepymole
Copy link
Contributor Author

/hold

Wait until PingCAP-QE/ci#450 is merged.

@ti-chi-bot ti-chi-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 28, 2021
@Rustin170506 Rustin170506 mentioned this pull request Oct 31, 2021
Closed
10 tasks
Ehco1996
Ehco1996 approved these changes Nov 1, 2021
View reviewed changes
Copy link
Contributor

@Ehco1996 Ehco1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@Ehco1996: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

purelind
purelind approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@purelind purelind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

@purelind: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Mini256
Copy link
Member

Mini256 commented Nov 3, 2021

@gozssky, Are the new CI checks required for the release branches?

@sleepymole
Copy link
Contributor Author

@gozssky, Are the new CI checks required for the release branches?

The new release-5.3 is required.

@sleepymole
Copy link
Contributor Author

/unhold

@ti-chi-bot ti-chi-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 3, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 3, 2021
@Mini256
Copy link
Member

Mini256 commented Nov 3, 2021

The new release-5.3 is required.

Get! We will add it in the subsequent PR that will add the release-5.3 branch.

cc: @zhouqiang-cl

@Mini256
Copy link
Member

Mini256 commented Nov 3, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: efab899

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 3, 2021
@ti-chi-bot ti-chi-bot merged commit 086350b into ti-community-infra:main Nov 3, 2021
@ti-chi-bot
Copy link
Member

@gozssky: Updated the config configmap in namespace prow at cluster default using the following files:

  • key config.yaml using file prow/config/config.yaml

In response to this:

Since we have merged DM repo into TiCDC repo https://github.com/pingcap/ticdc/pull/3122, we need to add idc-jenkins-ci-ticdc/dm-integration-test and idc-jenkins-ci-ticdc/dm-compatibility-test as a required status in TiCDC CI.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sleepymole sleepymole deleted the modify-ticdc-required-status branch November 3, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rustin170506 Rustin170506 Rustin170506 approved these changes

@Ehco1996 Ehco1996 Ehco1996 approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@purelind purelind purelind approved these changes

@Mini256 Mini256 Mini256 approved these changes

Assignees
No one assigned
Labels
contribution This PR is from a community contributor. first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. ok-to-test Indicates a PR is ready to be tested. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sleepymole @ti-chi-bot @Mini256 @purelind @lichunzhu @Ehco1996 @Rustin170506