Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✏️ Fix typo in syntax for using the GitHub Action tag directly (instead of with Docker) in README #39

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

art049
Copy link
Contributor

@art049 art049 commented Oct 27, 2020

It seems that github action uses @ instead of : to define the version.

@tswfi
Copy link

tswfi commented Dec 5, 2020

Just added this action to a project and the current readme is right with ":". @ doesn't work.

@art049
Copy link
Contributor Author

art049 commented Dec 5, 2020

This fix was intended for the use of the non dockerized version.
In this case - uses: tiangolo/latest-changes:0.0.3 didn't work as "pure" github actions uses @
But it worked fine for the dockerized one like this: - uses: docker://tiangolo/latest-changes:0.0.3
Maybe github allows : as well now

@tswfi
Copy link

tswfi commented Dec 5, 2020

Oh, my bad then.

@tiangolo tiangolo changed the title Fix github actions version tag in README ✏️ Fix typo in syntax for using the GitHub Action tag directly (instead of with Docker) in README Nov 2, 2023
@tiangolo tiangolo added the docs Improvements or additions to documentation label Nov 2, 2023
@tiangolo
Copy link
Owner

tiangolo commented Nov 2, 2023

Thank you @art049! 🙇 ☕

@tiangolo tiangolo merged commit 05613c0 into tiangolo:main Nov 2, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants