Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UefiCpuPkg: Fix unchecked returns and potential integer overflows #6397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

UefiCpuPkg: Fix unchecked returns and potential integer overflows #6397

wants to merge 1 commit into from

Conversation

cfernald
Copy link

@cfernald cfernald commented Nov 1, 2024

Description

Resolves several issues in UefiCpuPkg related mostly to the following:

  1. Unchecked returns leading to potential NULL or uninitialized access.
  2. Potential unchecked integer overflows.
  3. Incorrect comparison between integers of different sizes.
  • Breaking change?
    • Breaking change - Does this PR cause a break in build or boot behavior?
    • Examples: Does it add a new library class or move a module to a different repo.
  • Impacts security?
    • Security - Does this PR have a direct security impact?
    • Examples: Crypto algorithm change or buffer overflow fix.
  • Includes tests?
    • Tests - Does this PR include any explicit test code?
    • Examples: Unit tests or integration tests.

How This Was Tested

Shipped in platforms with Project Mu.

Integration Instructions

N/A

@kenlautner @cfernald
UefiCpuPkg: Fix unchecked returns and potential integer overflows
f89d2e1 
Resolves several issues in UefiCpuPkg related to:

1. Unchecked returns leading to potential NULL or uninitialized access.
2. Potential unchecked integer overflows.
3. Incorrect comparison between integers of different sizes.

Co-authored-by: kenlautner <85201046+kenlautner@users.noreply.github.com>
Signed-off-by: Chris Fernald <chfernal@microsoft.com>
@niruiyu niruiyu added the push Auto push patch series in PR if all checks pass label Nov 6, 2024
@lgao4
Copy link
Contributor

lgao4 commented Nov 12, 2024

@cfernald , @niruiyu , seemly this is the security bug fix. Do you plan to merge it for this stable tag 202411?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@niruiyu niruiyu niruiyu approved these changes

@jiaxinwu jiaxinwu Awaiting requested review from jiaxinwu

@kraxel kraxel Awaiting requested review from kraxel

@rahul1-kumar rahul1-kumar Awaiting requested review from rahul1-kumar

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
push Auto push patch series in PR if all checks pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cfernald @lgao4 @niruiyu @kenlautner