Add notifications and sounds to schema #1064
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to specific app notifications and sounds in the schema.
Here is an example:
This change makes the
Schema
andSchemaJSON
fields ofApplet
public, so that embedders can inspect the schema and access the sound files that are referenced byschema.Sound
.Also, the
File
type is moved toruntime/modules
to avoid a circular dependency betweenruntime
andschema
.