Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BACK-2744] Add AnyHigh and AnyLow to Summaries #127

Merged
merged 9 commits into from
Jan 5, 2024
Merged

Conversation

Roukoswarf
Copy link
Contributor

No description provided.

ewollesen
ewollesen previously approved these changes Nov 8, 2023
Copy link
Contributor

@ewollesen ewollesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just questions, assuming those questions don't turn up issues, then I think this is GTG.

api/mappers.go Show resolved Hide resolved
api/mappers.go Show resolved Hide resolved
client/types.go Show resolved Hide resolved
client/types.go Show resolved Hide resolved
patients/tide.go Outdated Show resolved Hide resolved
client/client.go Outdated Show resolved Hide resolved
client/types.go Show resolved Hide resolved
ewollesen
ewollesen previously approved these changes Nov 10, 2023
Copy link
Contributor

@ewollesen ewollesen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm sure you're aware, but just in case, make sure to have QA do a full regression, in case something got missed with all the pointer changes. :)

@Roukoswarf Roukoswarf merged commit 0e82515 into master Jan 5, 2024
2 checks passed
@Roukoswarf Roukoswarf deleted the anyhigh-anylow branch January 5, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants