-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
One day tideline scroll inconsistent location of time #88
Comments
@skrugman @HowardLook @brandonarbiter Passing this to you. The scrolling behavior is, I believe, as designed (namely, the arrow buttons scroll you exactly 24 hours from your current location), and I don't find it confusing myself, but I'm not a good judge of these things anymore. Also, I believe Jenise commented that she found this confusing as well. Snap-to-midnight would probably take me a day or so of work, maybe less. |
Here's an exact reconstruction of how I got confused. I know that a temp happened on March 14th at 3am. I was looking for it in the data, so I arrowed it back to March 14th. I look down at the basals, and oh $|-|!7 it's not there. OMG, what did I screw up in the processing? I worry. But, I just click the arrow some more to see if I screwed up the dates or something, and now it's March 13th. My temp basal shows up, Eureka! But wait, why does the temp that should happen on the 14th happen on the 13th? I ponder it for a bit, finally look at the legend at the top of the graph and notice that I'm looking at 6am to 6am. So, it says March 13th because that is the "primary" day, but it's actually showing me March 14th. All said and done, I've been scared into thinking I screwed something up, when really I just didn't know what the UI was trying to tell me. Jana told me in chat that it is done this way so that a user can define what they believe a day is (i.e. 7 to 7 or whatever) and then just look at that over and over again. The current UI doesn't actually allow me to precisely define my "day" (I can click and drag the graph, but have no indication of what time it's actually on). It also doesn't seem to be consistent on a per-user basis, so if you are a doctor looking at 50 patients and each of them have data that ends up with a viewport centered on different times, it's gonna cause confusion for them to try to figure out what they are actually looking at. |
So a note to add to the discussion: the other thing this relates to is showing one vs. two date strings in the top bar. I had two contra Sara's design at one point because I found myself confused in the same way @cheddar is. The compromise @skrugman and I reached was to use one, and it changes over when midnight crosses the centerline of your viewport, so the label always reflects whatever day is taking the majority of your viewport (where majority here is > 50%) and to replace the '12 am' ticks in the horizontal axis with date indicators (e.g., Mar 12). So, something to think about is that instead of changing the scrolling behavior (by snapping it to midnight or whatever), it may also make sense to rethink the feedback provided in the navigation bar as to what your viewport domain is. Perhaps we can make that more descriptive and precise somehow. (Even just adding the time you're seeing at the left edge would help, I imagine.) |
Could the label stick to the time of day?
|
Kent, the one on the x-axis at the top sticks to midnight. The label that I actually look at is the one between the arrows. |
weather.com addresses this in a clever way. See attached [or of course you They do four things that caught my attention and make it pretty easy to see
I mocked it up in a PDF and provided the sample, attached. I do not applaud Thanks, Brandon Arbiter On Wed, Apr 16, 2014 at 2:59 PM, cheddar notifications@github.com wrote:
|
@brandonarbiter I don't think you can attach things to GitHub comments. You'll have to send it to us outside of GitHub. |
You can paste images that are copied to the clipboard. I do it all the time. Howard Look Tidepool is an open source, not-for-profit effort to build an open data platform and better applications that reduce the burden of Type 1 Diabetes and accelerate the commercialization of closed-loop systems.
|
So @brandonarbiter there are already dates instead of 12 am labels... I don't know what old version you created your images from, but it's not what's been in the tideline code for some time now... |
@jebeck I think the problem comes from the size/spacing. I would say this is a P3. I would make the .d3-axis text 10px and put the day date above it 11px (in screen shot mock up) |
Yes, this design from @skrugman is nearly what I was going for, if I wasn't So Sara, in the example you just sent out, while above "12 am" it reads I hope this would address the confusion @cheddar and Jenise report. They Regarding prioritization, Jana would you offer some indication of time Thanks, Brandon Arbiter On Thu, Apr 17, 2014 at 6:03 AM, skrugman notifications@github.com wrote:
|
Speaking of weather-related sites, have you guys ever seen http://www.weatherspark.com? I'm not sure if it's helpful or not for us, but it's my favorite weather thing. They default to a 2-day view and have a pretty constant mouseover that gives you tons of information. Regarding the proposal to adjust what's in the x-axis, the problem is that I don't look at the x-axis. Jana pointed this out yesterday, but I apparently did a bad job of explaining that the only thing my eyes are drawn to is the date between the arrows. Adjusting the x-axis might make it easier for me to orient myself after getting disoriented by looking at the date between the arrows, but it's still a 2-step process
So, in my mind, it's better but is not a resolution. |
Point taken @cheddar , thanks for clarifying. I bet that being more explicit about multiple dates in the x-axis will help. But I also think you're right that having a single date highlighted in the header, while two days of information are being displayed, is a bit confusing. @skrugman , do you want to take a stab at this? Cheddar's weather link shows a viable method to display multiple days in the header. Screenshot attached. |
It's cold where you are Brandon. Go somewhere better :P |
Arg. #Boston. Brandon Arbiter On Thu, Apr 17, 2014 at 9:00 AM, cheddar notifications@github.com wrote:
|
@brandonarbiter To answer your timing question, it's really hard to say given the number of ideas flying around. If we really want to explore lots of different possibilities, it feels like a couple to three days effort to me, with rounds of feedback and then trying yet more things, like we did to some extent for the two-week view labels. I believe that many of the issues around modifying the dates (except for the sticky on the left thing you've suggested) are things that I've more-or-less solved because of two-week view, but I don't want to underestimate how long it could take to get things perfect. |
Reminder -- on the list of priorities, this is rather low. Although it's On Thu, Apr 17, 2014 at 9:28 AM, Jana Beck notifications@github.com wrote:
Kent Quirk Tidepool is an open source, not-for-profit effort to build an open data |
I agree. We have a bunch of input for sara to consider. Let's leave this in design for now. Once we have some suggested solutions from sara, we will revisit development timing. Sound good? Sent from my iPhone
|
Sounds good @brandonarbiter, with one caveat: This is a place where the technical limitations of what is easy and hard in D3 really matters, IMO, so I would like to be involved at an earlier stage in terms of discussing redesign possibilities, not just expected to implement whatever new version @skrugman comes up with, as has been our pattern up to now. Is that fair? |
That is fair and my expectation. My suggestion is simply let's pause active I'll just make sure you are in the loop on all email/Git/meeting Brandon Arbiter On Thu, Apr 17, 2014 at 12:27 PM, Jana Beck notifications@gh.neting.ccwrote:
|
Just posted a time for early next week to discuss this design. Currently Brandon Arbiter On Fri, Apr 25, 2014 at 4:15 AM, skrugman notifications@github.com wrote:
|
Thanks @brandonarbiter. @skrugman can you provide a little more information on the proposed design? The interaction is not 100% clear to me. Is the proposal that the dates on appear at midnight and move as you scroll? That is, we're not going with any "sticky" labels? |
@jebeck yes, the dates scroll with the timeline. Im not sure what you mean On Fri, Apr 25, 2014 at 6:30 PM, Jana Beck notifications@github.com wrote:
|
@skrugman - See the example from Weather.com for "sticky labels". (The In the image, the first hour displayed is 8pm. Under the time label that When Jana refers to "sticky labels", she's referring to the first idea - Brandon Arbiter On Sun, Apr 27, 2014 at 12:13 PM, skrugman notifications@github.com wrote:
|
From my notes, here's what we agreed to try @skrugman: This includes the following changes:
|
Thanks for providing that picture, Jana. To me, the two key takeaways, both
On Wed, May 21, 2014 at 10:53 PM, Jana Beck notifications@gh.neting.ccwrote:
|
Okay awesome. On Thu, May 22, 2014 at 6:10 PM, brandonarbiter notifications@gh.neting.ccwrote:
*Sara Krugman * *Tidepool *An open source, not-for-profit effort to build an open data Phone : +45 42 74 68 17 |
Addressed in https://trello.com/c/yFdyqn3Y, change came in via #151. |
When I scroll the one-day view in tideline, sometimes it shows me midnight to midnight. Other times it shows me 3am to 3am. Other times still, it's 6pm to 6pm.
Given that it is a day view and that the thingie at the top tells me which day it is, I expect it to be midnight-to-midnight. This has caused me confusion multiple times when trying to figure out what is going on with basals. The basal tooltips don't have the time included either, so it's really hard to figure out what time I'm actually looking at.
I'd prefer that it always show me the same time range, if we do that, then you cannot see clearly what happened over night, but that I think should be solved by adding a 3-day view (or 2-day view). At a minimum, though, I'd like to have something that will allow me to "snap-to-day" so that I can be confident that it's showing me midnight to midnight.
The text was updated successfully, but these errors were encountered: