Rewrite segmentutil to be simpler and more correct #117
Conversation
Also include some timing code that I found useful when debugging and probably doesn't hurt to have included.
|
In addition to our discussion of the lack of |
|
Ok, I looked into the lack of value and it turns out that it's happening because of the time when there were two pumps operating at the same time. We throw away the scheduled basals because that's what we decided to do when we get overlapping scheduled basals, and then there's nothing for the temp to apply to, so no percentage to multiply. So, I'm thinking the right thing to do here is to throw away the temp as well if it has a percent. The other thing we can do is zero them out. Let me know if you prefer zeroing, 'cause I'm gonna start on implementing the throw away logic. |
If we get overlapping scheduled basals, we throw them away. This means that there are sometimes areas where we have percentage temps that don't have a scheduled basal to apply to. We need to throw these away as well, because we don't know what the actual amount delivered was.
|
Errr, the changes were simple, so they are done already. @jebeck, it seems to be rendering well. Please check and merge at will. |
|
@cheddar The validator is still finding segments without a |
Had to move smooshing to a later stage, but not overlaps are handled better. Also included a bunch of new tests to verify the behavior
|
@jebeck Ok, went in and fixed a bunch of stuff. This was a fun one. I found one thing. Fixed it, uncovered another, fixed it, uncovered another, fixed it. Probably went through like 4 different bugs in both the carelink parser and the blip-side processing as well. But, I believe it is now, stupid fingers, actually complete. Blip changes are in master and I'm going to push the newest jellyfish to devel so that you can see stuffs. |
…fication Rewrite segmentutil to be simpler and more correct
Also include some timing code that I found useful when debugging and probably doesn't hurt to have included.
@jebeck Can you give this a once over? For
segmentutil.jsit might be easier to just look at the file, 'cause even though github is trying to show you a diff, it's a complete rewrite with nothing but the top couple of lines maintained.