chore: default to ipv4 #637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
merge #629 for less lint warnings first
This will set the default to IPv4 for node 17,18,19 support. Beginning with 17 the default setting of
0will select a IPv6 (https://stackoverflow.com/a/73732144/5193915) and it won't connect to ADB to get the device or emulator and stops.Setting it to IPv4 will build apps with all node versions up to 19 again!
We could make this a config setting later but since the default was ipv4 before too it shouldn't hurt to keep it at that level.