chore: update search path #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes tidev/titanium-sdk#13651 |
ewanharris
reviewed
Mar 5, 2023
cb1kenobi
requested changes
Apr 4, 2023
| }, | ||
| proguard: fs.existsSync(proguardPath) ? proguardPath : null, | ||
| proguard: null, |
There was a problem hiding this comment.
Just a FYI, I'm pretty sure we never got around to using proguard. We had a ticket (https://jira-archive.titaniumsdk.com/TIMOB/TIMOB-14740) to auto-generate it the config file, but it turned out to be super complex as we'd need a list of any and all native classes being used and I think that includes modules. Oh well.
Co-authored-by: Chris Barber <chris@cb1inc.com>
cb1kenobi
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as far as my test show this is the only part that is left so it still needs the obsolete Android SDK Tools folder:
in fact: building apps already works fine, just
ti infocomplains aboutUnable to locate an Android SDK.Tested building to device and emulator, building a module and apk