Fix packages #649
Merged
Fix packages #649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
approved these changes
Mar 30, 2023
There was a problem hiding this comment.
I did a code review and it looks fine, however testing this is nearly impossible. Overwriting the node-titanium-sdk in the SDK before or after build is a lot of work. I tried and I still see the error, so something isn't right.
So, I'm going to approve this, merge it, ship a new node-titanium-sdk. Then we can properly test the SDK. If it doesn't fix the callsite issue, then we can iterate until we do fix it.
|
I'll do some tests later. I always used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after weeks of testing I found that babel was the issue!
Use Squash & Merge to reduce the test commit logs