fix: arm mac emulator fix #652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When will this be merged? |
|
I've put it in my Slack post for a potential 12.3.1 PR list 👍 so hopefully soon |
cb1kenobi
reviewed
Apr 7, 2024
cb1kenobi
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't test it as I don't have a Arm Mac.
Having those parameters on an Arm Mac won't start the emulator, it will stop with a black screen.
In the old PR at #629 I've already added a check so it won't include it. But if you have a SDCard assigned in your emulator it will still use the
-sdcardparameter.This PR will ignore both parameters if you are using an Arm Mac. The CPU check part is from:
nodejs/node#41900 (comment)