Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(all): Update node dependencies #573

Merged
merged 16 commits into from
Sep 21, 2022
Merged

fix(all): Update node dependencies #573

merged 16 commits into from
Sep 21, 2022

Conversation

m1ga
Copy link
Contributor

@m1ga m1ga commented Jul 2, 2022 •
edited
Loading

  • update node dependencies
  • update node version to 14 in github actions
  • update SDK version in github actions
  • linted some files to make the linter happy

waiting for: tidev/karma-titanium-launcher#119

@m1ga
Copy link
Contributor Author

m1ga commented Jul 2, 2022

Found the solution to the karma part!

We'll need to merge the ti.socket PR first to support v4: tidev/titanium-socketio#164
Then change https://github.com/tidev/karma-titanium-launcher/blob/develop/lib/project-manager.js#L15-L24 and release karma-launcher + karma-client. After that karma will work again 👍

@m1ga m1ga mentioned this pull request Jul 7, 2022
Open
5 tasks
hansemannn
hansemannn approved these changes Aug 3, 2022
View reviewed changes
Copy link
Contributor

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Pretty cool effort and tooling, will add that to more modules as well.

@m1ga m1ga mentioned this pull request Sep 21, 2022
Merged
2 tasks
@hansemannn hansemannn merged commit 9234d1e into tidev:master Sep 21, 2022
@m1ga m1ga deleted the nodedeps branch September 21, 2022 12:22
@m1ga
Copy link
Contributor Author

m1ga commented Sep 21, 2022

👍 thanks! And most of the dependabot PRs are now resolved too 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m1ga @hansemannn