Workshop test on Graf weight time #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hfrick
commented
May 17, 2023
| surv_obj <- survival::Surv(time = c(10, 12), event = c(0, 1)) | ||
| expect_equal( | ||
| parsnip:::graf_weight_time_vec(surv_obj, eval_time = NULL), | ||
| logical(0) |
There was a problem hiding this comment.
Just to confirm: this is the result we want to see for eval_time = NULL? Also noting that, unlike the case for eval_time = NA, this does not return anything of the same length as the Surv object.
| eval_11[!na_11], | ||
| seq(2, 10, by = 2) | ||
| parsnip:::graf_weight_time_vec(surv_obj, eval_time = NA), | ||
| c(NA, NA) |
There was a problem hiding this comment.
I think this makes sense as a return value for eval_time = NA but as for the NULL case, just wanted you to confirm here
Comment on lines
+22
to
+25
| expect_equal( | ||
| parsnip:::graf_weight_time_vec(observed_time_gt_eval_time, eval_time = eval_time_10), | ||
| rep(eval_time_10, 2) | ||
| ) |
There was a problem hiding this comment.
Noting here that the modification to avoid data leakage (subtracting eps) is flying under the radar of expect_equal(). Same for Category 1.
Conflicts: tests/testthat/_snaps/parsnip-survival-censoring-weights.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR workshops the test on
parsnip:::graf_weight_time_vec(). The differences are probably easier to read commit-by-commit rather than aggregated.