merge upstream speedups (#1072, #1073)

tidymodels · Feb 26, 2024 · dc6b120 · dc6b120
2 parents 9b54931 + 5491946
commit dc6b120
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/R/fit_helpers.R b/R/fit_helpers.R
@@ -9,9 +9,12 @@ form_form <-
     if (inherits(env$data, "data.frame")) {
       check_outcome(eval_tidy(rlang::f_lhs(env$formula), env$data), object)
 
+      encoding_info <- get_encoding(class(object)[1])
       encoding_info <-
-        get_encoding(class(object)[1]) %>%
-        dplyr::filter(mode == object$mode, engine == object$engine)
+        vctrs::vec_slice(
+          encoding_info,
+          encoding_info$mode == object$mode & encoding_info$engine == object$engine
+        )
 
       remove_intercept <- encoding_info %>% dplyr::pull(remove_intercept)
       if (remove_intercept) {

diff --git a/R/translate.R b/R/translate.R
@@ -102,8 +102,6 @@ translate.default <- function(x, engine = x$engine, ...) {
 
 get_model_spec <- function(model, mode, engine) {
   m_env <- get_model_env()
-  env_obj <- rlang::env_names(m_env)
-  env_obj <- grep(model, env_obj, value = TRUE)
 
   res <- list()