Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't use check_outcome() when using sparklyr #677

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt commented Mar 12, 2022

To close #671

library(sparklyr)
#> 
#> Attaching package: 'sparklyr'
#> The following object is masked from 'package:stats':
#> 
#>     filter
library(parsnip)

sc <- spark_connect("local")
iris_tbl <- sdf_copy_to(sc, iris)

decision_tree(engine = "spark") %>%
  set_mode("classification") %>%
  fit(Species ~ Sepal_Length + Petal_Length, iris_tbl)
#> parsnip model object
#> 
#> Formula: Species ~ Sepal_Length + Petal_Length
#> 
#> DecisionTreeClassificationModel (uid=decision_tree_classifier__6a7e32a5_0707_461f_bfe5_d825c6b6f9f1) of depth 5 with 17 nodes

spark_disconnect(sc)

Created on 2022-03-11 by the reprex package (v2.0.1)

Should I add a corresponding test in https://github.com/tidymodels/extratests?

@juliasilge
Copy link
Member

Unless I am misunderstanding, won't the existing Spark tests cover this?

@topepo
Copy link
Member

topepo commented Mar 13, 2022

The existing tests should catch this (since they are currently failing).

R/fit_helpers.R Show resolved Hide resolved
R/fit_helpers.R Show resolved Hide resolved
@topepo topepo merged commit 7710967 into main Mar 14, 2022
@topepo topepo deleted the check_outcome-sparklyr branch March 14, 2022 16:29
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration with sparklyr is failing, starting with parsnip 2.0
4 participants