Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fit_xy() for censored regression #829

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Conversation

hfrick
Copy link
Member

@hfrick hfrick commented Oct 13, 2022

This PR enables the matrix interface via fit_xy() for the "censored regression" mode.

Tests for this are in censored: tidymodels/censored#225

@hfrick hfrick marked this pull request as ready for review October 13, 2022 21:48
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Super clean pair of PRs. :)

NEWS.md Outdated Show resolved Hide resolved
@simonpcouch
Copy link
Contributor

Will leave to you to merge, @hfrick!

Co-authored-by: Simon P. Couch <simonpatrickcouch@gmail.com>
@hfrick hfrick merged commit 025cc59 into main Oct 25, 2022
@hfrick hfrick deleted the fit_xy-censored-regression branch October 25, 2022 13:53
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants