Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for flexsurvspline engine for survival_reg model spec #831

Merged
merged 13 commits into from
Nov 3, 2022
Merged

Adds support for flexsurvspline engine for survival_reg model spec #831

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
27f267e
Adds support for flexsurvspline engine for survival_reg model spec
mattwarkentin Oct 27, 2022
92abf70
Add PR number to NEWS
mattwarkentin Oct 27, 2022
68e6b6a
leave deprecated `surv_reg()` as is
hfrick Oct 28, 2022
387d316
make `k` tunable
hfrick Oct 28, 2022
4152982
update `inst/models.tsv`
hfrick Oct 28, 2022
9671db0
update engine docs and knit
hfrick Oct 28, 2022
99b86e8
document()
hfrick Oct 28, 2022
5aadb88
update news, add contributor
hfrick Oct 28, 2022
eff3054
import also the generic
hfrick Oct 28, 2022
3cdca0f
Merge branch 'main' into mattwarkentin-main
topepo Nov 3, 2022
52003ef
remove engine arg from template
topepo Nov 3, 2022
ec6caf6
notes about case weights
topepo Nov 3, 2022
dcbd28f
render docs
topepo Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ export(svm_rbf)
export(tidy)
export(translate)
export(translate.default)
export(tunable.survival_reg)
export(tune)
export(update_dot_check)
export(update_engine_parameters)
Expand Down
6 changes: 3 additions & 3 deletions R/tunable.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,7 @@ brulee_multinomial_engine_args <-

flexsurvspline_engine_args <-
tibble::tibble(
name = c("num_knots"),
name = c("k"),
mattwarkentin marked this conversation as resolved.
Show resolved Hide resolved
call_info = list(
list(pkg = "dials", fun = "num_knots")
),
Expand Down Expand Up @@ -321,8 +321,8 @@ tunable_mlp <- function(x, ...) {
res
}

# Lazily registered in .onLoad()
tunable_survival_reg <- function(x, ...) {
#' @export
tunable.survival_reg <- function(x, ...) {
res <- NextMethod()
if (x$engine == "flexsurvspline") {
res <- add_engine_parameters(res, flexsurvspline_engine_args)
Expand Down