Skip to content

Commit

Permalink
RC 0.1.0 (#238)
Browse files Browse the repository at this point in the history
* Remove revdep database from repo

* Quiet NOTE about using stats library

* No more LazyData, move utils + stats to Suggests

* Remove AmesHousing, use ames in vignette

* Revdep checks

* Update CRAN comments

* Bump version number
  • Loading branch information
juliasilge authored May 8, 2021
1 parent 307c157 commit ed539d7
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 19 deletions.
7 changes: 3 additions & 4 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: rsample
Title: General Resampling Infrastructure
Version: 0.0.9.9000
Version: 0.1.0
Authors@R: c(
person(given = "Julia", family = "Silge", email = "julia.silge@rstudio.com", role = c("aut", "cre"), comment = c(ORCID = "0000-0002-3671-836X")),
person(given = "Fanny", family = "Chow", email = "fannybchow@gmail.com", role = c("aut")),
Expand All @@ -16,7 +16,6 @@ Imports:
rlang (>= 0.4.10),
methods,
generics,
utils,
tidyselect,
furrr,
tidyr,
Expand All @@ -27,11 +26,12 @@ Imports:
Depends:
R (>= 3.2)
Suggests:
utils,
stats,
ggplot2,
testthat,
rmarkdown,
knitr,
AmesHousing,
recipes (>= 0.1.4),
broom,
xml2,
Expand All @@ -42,6 +42,5 @@ BugReports: https://github.com/tidymodels/rsample/issues
License: MIT + file LICENSE
Encoding: UTF-8
VignetteBuilder: knitr
LazyData: true
RoxygenNote: 7.1.1.9001
Roxygen: list(markdown = TRUE)
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# rsample (development version)
# rsample 0.1.0

* Fixed how `mc_cv()`, `initial_split()`, and `validation_split()` use the `prop` argument to first compute the assessment indices, rather than the analysis indices. This is a minor but **breaking change** in some situations; the previous implementation could cause an inconsistency in the sizes of the generated analysis and assessment sets when compared to how `prop` is documented to function (#217, @issactoast).

Expand Down
2 changes: 1 addition & 1 deletion R/make_strata.R
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
make_strata <- function(x, breaks = 4, nunique = 5, pool = .1, depth = 20) {

default_pool <- 0.1
num_vals <- unique(na.omit(x))
num_vals <- unique(stats::na.omit(x))
n <- length(x)
if (length(num_vals) <= nunique | is.character(x) | is.factor(x)) {
x <- factor(x)
Expand Down
4 changes: 2 additions & 2 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## Release Summary

This is the 8th CRAN release of rsample. This release fixes bugs, updates the inheritance structure for rsample objects, and adds developer-friendly tools for package developers or analysts depending on rsample. This release also marks a **change in maintainer** from Max Kuhn <max@rstudio.com>, to Julia Silge <julia.silge@rstudio.com>.
This is the 9th CRAN release of rsample. This release fixes bugs, improves error messages, and adds flexibility for users when stratifying sampling. This release also marks a **change in license** from GPL-2 to MIT; see [consent from copyright holders here](https://github.com/tidymodels/rsample/issues/226).

## Test environments

Expand All @@ -16,7 +16,7 @@ This is the 8th CRAN release of rsample. This release fixes bugs, updates the in

## revdepcheck results

We checked 23 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 27 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
13 changes: 6 additions & 7 deletions revdep/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,22 +2,21 @@

|field |value |
|:--------|:----------------------------|
|version |R version 4.0.3 (2020-10-10) |
|os |macOS Mojave 10.14.6 |
|version |R version 4.0.5 (2021-03-31) |
|os |macOS Big Sur 10.16 |
|system |x86_64, darwin17.0 |
|ui |RStudio |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/Denver |
|date |2021-02-16 |
|date |2021-05-07 |

# Dependencies

|package |old |new |Δ |
|:-------|:-----|:-----------|:--|
|rsample |0.0.8 |0.0.8.9001 |* |
|pillar |NA |1.4.99.9006 |* |
|package |old |new |Δ |
|:-------|:-----|:----------|:--|
|rsample |0.0.9 |0.0.9.9000 |* |

# Revdeps

2 changes: 1 addition & 1 deletion revdep/cran.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
## revdepcheck results

We checked 23 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.
We checked 27 reverse dependencies, comparing R CMD check results across CRAN and dev versions of this package.

* We saw 0 new problems
* We failed to check 0 packages
Expand Down
Binary file removed revdep/data.sqlite
Binary file not shown.
4 changes: 1 addition & 3 deletions vignettes/Applications/Recipes_and_rsample.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,7 @@ Before discussing how `rsample` can use recipes, let's look at an example recipe
For illustration, the Ames housing data will be used. There are sale prices of homes along with various other descriptors for the property:

```{r ames-data, message=FALSE}
library(AmesHousing)
ames <- make_ames()
names(ames)
data(ames, package = "modeldata")
```

Suppose that we will again fit a simple regression model with the formula:
Expand Down

0 comments on commit ed539d7

Please sign in to comment.