Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprint indices instead of entire data object #259

Merged
merged 2 commits into from
Sep 27, 2021
Merged

Fingerprint indices instead of entire data object #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3497c08
Fingerprint indices instead of entire data object
juliasilge Sep 23, 2021
87ffd6d
Only map through splits once, update NEWS
juliasilge Sep 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@

* Escalated the deprecation of the `gather()` method for `rset` objects to a hard deprecation. Use `tidyr::pivot_longer()` instead (#257).

* Changed resample "fingerprint" to hash the indices only rather than the entire resample result (including the data object). This is much faster and will still ensure the same resample for the same original data object (#259).

# rsample 0.1.0

* Fixed how `mc_cv()`, `initial_split()`, and `validation_split()` use the `prop` argument to first compute the assessment indices, rather than the analysis indices. This is a minor but **breaking change** in some situations; the previous implementation could cause an inconsistency in the sizes of the generated analysis and assessment sets when compared to how `prop` is documented to function (#217, @issactoast).
Expand Down
3 changes: 2 additions & 1 deletion R/rset.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,8 @@ new_rset <- function(splits, ids, attrib = NULL,
res <- add_class(res, cls = subclass)
}

fingerprint <- rlang::hash(res)
fingerprint <- map(res$splits, function(x) list(x$in_id, x$out_id))
fingerprint <- rlang::hash(fingerprint)
attr(res, "fingerprint") <- fingerprint

res
Expand Down