merge pr #149: use condense_control()

tidymodels · Sep 23, 2022 · 7822d86 · 7822d86
2 parents 6a9aaa2 + 2b63ba3
commit 7822d86
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -29,7 +29,7 @@ Imports:
     rlang (>= 0.4.0),
     tibble (>= 2.1.3),
     purrr (>= 0.3.2), 
-    parsnip (>= 0.0.4),
+    parsnip (>= 1.0.1.9000),
     workflows (>= 0.2.3),
     recipes (>= 0.2.0),
     rsample (>= 0.1.1),
@@ -64,3 +64,5 @@ Roxygen: list(markdown = TRUE)
 RoxygenNote: 7.2.0
 VignetteBuilder: knitr
 Config/testthat/edition: 3
+Remotes:
+    tidymodels/parsnip
diff --git a/NEWS.md b/NEWS.md
@@ -4,6 +4,10 @@ To be released as stacks 1.0.1.
 
 * Removes an unneeded data import attribute from the `tree_frogs` example data 
   and its associated objects.
+
+* `blend_predictions()` doesn't error anymore if `control` argument isn't a 
+  `control_grid()` object. Will work as long as the object passed to `control` 
+  includes the same elements as `control_grid()`.
 
 # stacks 1.0.0
 

diff --git a/R/blend_predictions.R b/R/blend_predictions.R
@@ -138,7 +138,7 @@ blend_predictions <- function(data_stack,
   if (!is.null(metric)) {
     check_inherits(metric, "metric_set")
   }
-  check_inherits(control, "control_grid")
+  control <- parsnip::condense_control(control, tune::control_grid())
   check_inherits(times, "numeric")
   check_empty_ellipses(...)