Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check condition for whether a workflow set is fitted is no longer correct #160

Closed
simonpcouch opened this issue Oct 4, 2022 · 1 comment · Fixed by #165
Closed

check condition for whether a workflow set is fitted is no longer correct #160

simonpcouch opened this issue Oct 4, 2022 · 1 comment · Fixed by #165

Comments

@simonpcouch
Copy link
Collaborator

  if (!"result" %in% colnames(candidates)) {
    cli_abort(
      "The supplied workflow_set must be fitted to resamples with 
       workflows::workflow_map() before being added to a data stack.",
      call = caller_env(0)
    )
  }

with unfitted workflowset, we see:

stacks() %>% add_candidates(wf_set)
#> Error in `.f()`:
#> ! The second argument to add_candidates() should inherit from one of `tune_results` or `workflow_set`, but its class is list.

The result column is now initialized, but left as empty tibbles, in workflow_set(). Related to #120.

@github-actions
Copy link

This issue has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant