Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revise errors for workflow sets #165

Merged
merged 1 commit into from
Oct 5, 2022
Merged

revise errors for workflow sets #165

merged 1 commit into from
Oct 5, 2022

Conversation

simonpcouch
Copy link
Collaborator

Fixes #160. Also splits the check into two cases, raising two different conditions.

If there are no fitted workflows in the workflowset, an error:

The supplied workflow set must be fitted to resamples with workflows::workflow_map() before being added to a data stack.

If only some of the workflows aren't fitted, a warning:

! Some elements of the supplied workflow set failed to evaluate with resamples.
i The workflows with ID `reg_lr` and `reg2_svm` will be excluded from the data stack.

@simonpcouch simonpcouch merged commit cbb1336 into main Oct 5, 2022
@simonpcouch simonpcouch deleted the wfset-160 branch October 5, 2022 19:36
simonpcouch added a commit that referenced this pull request Oct 6, 2022
@github-actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check condition for whether a workflow set is fitted is no longer correct
1 participant