Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(avoidance): use new turn signal algorithm #136

Conversation

satoshi-ota
Copy link

@satoshi-ota satoshi-ota commented Sep 22, 2022

Signed-off-by: satoshi-ota satoshi.ota928@gmail.com

Description

update turn signal logic (avoidance module)

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2022

Codecov Report

❗ No coverage uploaded for pull request base (feat/add-new-intersection-algorithm@c95623d). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                          Coverage Diff                          @@
##             feat/add-new-intersection-algorithm    #136   +/-   ##
=====================================================================
  Coverage                                       ?   2.53%           
=====================================================================
  Files                                          ?      51           
  Lines                                          ?    6629           
  Branches                                       ?    3383           
=====================================================================
  Hits                                           ?     168           
  Misses                                         ?    6218           
  Partials                                       ?     243           
Flag Coverage Δ
differential 2.51% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Signed-off-by: satoshi-ota <satoshi.ota928@gmail.com>
Copy link

@purewater0901 purewater0901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@purewater0901 purewater0901 merged commit 9352ee8 into tier4:feat/add-new-intersection-algorithm Sep 22, 2022
@satoshi-ota satoshi-ota deleted the feat/update-avoidance-turn-signal-algorithm branch September 22, 2022 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants