Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_auto_perception_rviz_plugin): rviz predicted objects multi-threading (#2065) #153

Merged

Conversation

tkimura4
Copy link
Collaborator

@tkimura4 tkimura4 commented Oct 14, 2022

Description

autowarefoundation#2065
hotfix to beta/v0.5.2-odaiba

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

…lti-threading (autowarefoundation#2065)

* Moved the processing of the messges -> markers to another thread to avoid processing multiple message processings in one rendeing step. However since I can not reproduce the problem, whether this helps or no it not confirmed

* misc

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
@codecov-commenter
Copy link

codecov-commenter commented Oct 14, 2022

Codecov Report

❗ No coverage uploaded for pull request base (beta/v0.5.2-odaiba@2683432). Click here to learn what that means.
Patch has no changes to coverable lines.

Additional details and impacted files
@@                 Coverage Diff                  @@
##             beta/v0.5.2-odaiba    #153   +/-   ##
====================================================
  Coverage                      ?   0.00%           
====================================================
  Files                         ?       9           
  Lines                         ?     665           
  Branches                      ?       0           
====================================================
  Hits                          ?       0           
  Misses                        ?     665           
  Partials                      ?       0           
Flag Coverage Δ
differential 0.00% <0.00%> (?)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@1222-takeshi 1222-takeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tkimura4 tkimura4 merged commit 9676275 into beta/v0.5.2-odaiba Oct 14, 2022
@tkimura4 tkimura4 deleted the hotfix/rviz_predicted_objects_threading branch October 14, 2022 04:13
0x126 pushed a commit that referenced this pull request Oct 17, 2022
…lti-threading (autowarefoundation#2065) (#153)

* Moved the processing of the messges -> markers to another thread to avoid processing multiple message processings in one rendeing step. However since I can not reproduce the problem, whether this helps or no it not confirmed

* misc

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>

Signed-off-by: tomoya.kimura <tomoya.kimura@tier4.jp>
Co-authored-by: Kenzo Lobos-Tsunekawa <kenzo.lobos@tier4.jp>
tkimura4 pushed a commit that referenced this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants